Skip to content

NIFI-1002: Added WebSocket support.#1231

Closed
ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak:nifi-1002-pr2
Closed

NIFI-1002: Added WebSocket support.#1231
ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak:nifi-1002-pr2

Conversation

@ijokarumawak
Copy link
Member

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

  • Added LICENSE and NOTICE files.
  • Fixed UnitTest errors.

- Added LICENSE and NOTICE files.
- Fixed UnitTest errors.
@olegz
Copy link
Contributor

olegz commented Nov 16, 2016

Reviewing

@asfgit asfgit closed this in 31ea50b Nov 16, 2016
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
- Added LICENSE and NOTICE files.
- Fixed UnitTest errors.

This closes apache#1231
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
- Added LICENSE and NOTICE files.
- Fixed UnitTest errors.

This closes apache#1231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants