Skip to content

NIFI-2954 Moved StandardPropertyValidator to nifi-utils, documented s…#1244

Closed
joewitt wants to merge 1 commit intoapache:masterfrom
joewitt:NIFI-2954
Closed

NIFI-2954 Moved StandardPropertyValidator to nifi-utils, documented s…#1244
joewitt wants to merge 1 commit intoapache:masterfrom
joewitt:NIFI-2954

Conversation

@joewitt
Copy link
Contributor

@joewitt joewitt commented Nov 18, 2016

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…cope/purpose of a few util libs, removed deps from nifi-utils.

@joewitt
Copy link
Contributor Author

joewitt commented Nov 18, 2016

Please comment on the jira discussion regarding impact to updating code. It does not impact already built items. Is not part of the public api.

@markap14
Copy link
Contributor

@joewitt all looks good. I have built a new instance of NiFi and verified that all seems to work okay. I like the recent change to keep package the same. It means that only pom's have to change. I'm a +1 on the most up-to-date commit!f

…cope/purpose of a few util libs, removed deps from nifi-utils.
@asfgit asfgit closed this in fb9cbcc Nov 21, 2016
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
… nifi-utils, documented scope/purpose of a few util libs, removed deps from nifi-utils.
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
… nifi-utils, documented scope/purpose of a few util libs, removed deps from nifi-utils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants