Skip to content

NIFI-3086 Updated TailFile.java to deal with windows paths that were …#1264

Closed
jtstorck wants to merge 2 commits intoapache:masterfrom
jtstorck:NIFI-3086
Closed

NIFI-3086 Updated TailFile.java to deal with windows paths that were …#1264
jtstorck wants to merge 2 commits intoapache:masterfrom
jtstorck:NIFI-3086

Conversation

@jtstorck
Copy link
Contributor

…breaking the regex parsing

Fixed documentation misspelling in TailFile.java
Fixed assertions in several tests in TestTailFile that were dependent on the received order of flowfiles, this was differing between Windows and MacOS/Linux

…breaking the regex parsing

Fixed documentation misspelling in TailFile.java
Fixed assertions in several tests in TestTailFile that were dependent on the received order of flowfiles, this was differing between Windows and MacOS/Linux
@JPercivall
Copy link
Contributor

JPercivall commented Nov 23, 2016

Hey @jtstorck, couple of check style issues:

[WARNING] src/test/java/org/apache/nifi/processors/standard/TestTailFile.java[581] (sizes) LineLength: Line is longer than 200 characters (found 224).
[WARNING] src/test/java/org/apache/nifi/processors/standard/TestTailFile.java[584] (sizes) LineLength: Line is longer than 200 characters (found 224).
[WARNING] src/test/java/org/apache/nifi/processors/standard/TestTailFile.java[587] (sizes) LineLength: Line is longer than 200 characters (found 214).
[WARNING] src/test/java/org/apache/nifi/processors/standard/TestTailFile.java[689] (sizes) LineLength: Line is longer than 200 characters (found 228).
[WARNING] src/test/java/org/apache/nifi/processors/standard/TestTailFile.java[692] (sizes) LineLength: Line is longer than 200 characters (found 214).

@JPercivall
Copy link
Contributor

+1

Fixes the windows issues. Thanks @jtstorck! I will merge it in.

@asfgit asfgit closed this in 066accc Nov 23, 2016
@jtstorck jtstorck deleted the NIFI-3086 branch November 23, 2016 18:02
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
…breaking the regex parsing Fixed documentation misspelling in TailFile.java Fixed assertions in several tests in TestTailFile that were dependent on the received order of flowfiles, this was differing between Windows and MacOS/Linux

This closes apache#1264

Signed-off-by: jpercivall <JPercivall@apache.org>
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
…breaking the regex parsing Fixed documentation misspelling in TailFile.java Fixed assertions in several tests in TestTailFile that were dependent on the received order of flowfiles, this was differing between Windows and MacOS/Linux

This closes apache#1264

Signed-off-by: jpercivall <JPercivall@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants