Skip to content

NIFI-3122: Do not validate component types in template anymore. Inste…#1283

Closed
markap14 wants to merge 1 commit intoapache:masterfrom
markap14:NIFI-3122
Closed

NIFI-3122: Do not validate component types in template anymore. Inste…#1283
markap14 wants to merge 1 commit intoapache:masterfrom
markap14:NIFI-3122

Conversation

@markap14
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…ad, just allow Ghost components to be created

…ad, just allow Ghost components to be created
@mcgilman
Copy link
Contributor

mcgilman commented Dec 8, 2016

Will review...

final List<String> prioritizers = conn.getPrioritizers();
if (prioritizers != null) {
for (final String prioritizer : prioritizers) {
if (!prioritizerClasses.contains(prioritizer)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can remove this check I believe we need to provide support for ghost Prioritizers. Otherwise, if a template references a Prioritizer that doesn't exist in this NiFi instance we would throw an exception when instantiating the Template.

Alternatively, we can keep this part of the verification in place. However, I think the ghost Prioritizer would be the preferred approach.

@joewitt
Copy link
Contributor

joewitt commented Oct 6, 2017

@markap14 @mcgilman can we get this closed out or pushed across?

@markap14 markap14 closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants