Skip to content

NIFI-3140: Restored optional type handling in FetchElasticsearchHttp#1288

Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-3140
Closed

NIFI-3140: Restored optional type handling in FetchElasticsearchHttp#1288
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-3140

Conversation

@mattyb149
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mattyb149
Copy link
Contributor Author

@gresockj Do you mind taking a look at this? I want to make sure I didn't miss something in the API or any potential differences between versions. For the Http processors I'd like to keep the least-common-denominator principle, since they are the alternative to the other Transport-based processors that require a particular (major) version. Thanks!

@JPercivall
Copy link
Contributor

+1

Visually verified code and did a contrib-check build. In a standalone instance I ran FetchElasticsearchHTTP with and without a "type" hitting a secure 2.3 ES instance. Also used EL for the URL to verify NIFI-3095. Everything worked as expected. Thanks @mattyb149 I will merge it in.

@asfgit asfgit closed this in 316cae1 Dec 2, 2016
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
This closes apache#1288

Signed-off-by: jpercivall <JPercivall@apache.org>
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
This closes apache#1288

Signed-off-by: jpercivall <JPercivall@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants