NIFI-3133: Ensure correct checks against Remote Group Ports#1297
Closed
mcgilman wants to merge 9 commits intoapache:masterfrom
Closed
NIFI-3133: Ensure correct checks against Remote Group Ports#1297mcgilman wants to merge 9 commits intoapache:masterfrom
mcgilman wants to merge 9 commits intoapache:masterfrom
Conversation
Contributor
mcgilman
commented
Dec 5, 2016
mcgilman
commented
- Ensuring that Remote Group Ports are always authorized according to their Remote Process Group.
- Ensuring that Remote Group Ports are always authorized according to their Remote Process Group.
- Using getSourceAuthorizable() when accessing flow files and content.
Contributor
|
Reviewing |
- Decouple local and remote connectable's to avoid ambiguity with self referencing RPGs.
JPercivall
reviewed
Dec 5, 2016
|
|
||
| final RemoteGroupPort remoteGroupPort = getRootGroup().findRemoteGroupPort(remoteGroupPortId); | ||
| if (remoteGroupPort == null) { | ||
| throw new ResourceNotFoundException("The component that generated this event is no longer part of the data flow."); |
Contributor
There was a problem hiding this comment.
I think there is a bit of copy paste error with this Exception message. My understanding is that this method is not limited to an "event".
Contributor
Author
There was a problem hiding this comment.
With the refactoring it is just events. However, there is still one spot that is unused that can now be removed. I'll update.
JPercivall
reviewed
Dec 5, 2016
| } | ||
|
|
||
| final RemoteGroupPort remoteGroupPort = root.findRemoteGroupPort(dto.getComponentId()); | ||
| if (connectable != null) { |
Contributor
There was a problem hiding this comment.
Looks like a copy/paste error, this should check "remoteGroupPort"
- Addressing comments from the PR.
- Fixed check verifying source/destination when creating a connection.
- Only showing the go to link when the source component is not a remote port.
- Removing unnecessary checking of remote group port authorization since it's handled by the parent RPG.
- Fixing issue showing the connection details dialog when the source component is a RPG.
- Ensuring the local connectable was found.
Contributor
|
+1 Visually verified code and did a contrib-check build. In a secure 3 node cluster ran through a number of tests involving RPGs, Input/Output ports and policies. I also ran a standalone instance to verify nothing there regressed. Everything worked as expected. Thanks @mcgilman I will squash and merge. |
dstreev
pushed a commit
to dstreev/nifi-1
that referenced
this pull request
Dec 9, 2016
…ccording to their Remote Process Group. NIFI-3133: - Using getSourceAuthorizable() when accessing flow files and content. NIFI-3133: - Decouple local and remote connectable's to avoid ambiguity with self referencing RPGs. NIFI-3133: - Addressing comments from the PR. NIFI-3133: - Fixed check verifying source/destination when creating a connection. NIFI-3133: - Only showing the go to link when the source component is not a remote port. NIFI-3133: - Removing unnecessary checking of remote group port authorization since it's handled by the parent RPG. NIFI-3133: - Fixing issue showing the connection details dialog when the source component is a RPG. NIFI-3133: - Ensuring the local connectable was found. This closes apache#1297 Signed-off-by: jpercivall <JPercivall@apache.org>
dstreev
pushed a commit
to dstreev/nifi-1
that referenced
this pull request
Dec 9, 2016
…ccording to their Remote Process Group. NIFI-3133: - Using getSourceAuthorizable() when accessing flow files and content. NIFI-3133: - Decouple local and remote connectable's to avoid ambiguity with self referencing RPGs. NIFI-3133: - Addressing comments from the PR. NIFI-3133: - Fixed check verifying source/destination when creating a connection. NIFI-3133: - Only showing the go to link when the source component is not a remote port. NIFI-3133: - Removing unnecessary checking of remote group port authorization since it's handled by the parent RPG. NIFI-3133: - Fixing issue showing the connection details dialog when the source component is a RPG. NIFI-3133: - Ensuring the local connectable was found. This closes apache#1297 Signed-off-by: jpercivall <JPercivall@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Dec 15, 2016
…ccording to their Remote Process Group. NIFI-3133: - Using getSourceAuthorizable() when accessing flow files and content. NIFI-3133: - Decouple local and remote connectable's to avoid ambiguity with self referencing RPGs. NIFI-3133: - Addressing comments from the PR. NIFI-3133: - Fixed check verifying source/destination when creating a connection. NIFI-3133: - Only showing the go to link when the source component is not a remote port. NIFI-3133: - Removing unnecessary checking of remote group port authorization since it's handled by the parent RPG. NIFI-3133: - Fixing issue showing the connection details dialog when the source component is a RPG. NIFI-3133: - Ensuring the local connectable was found. This closes #1297 Signed-off-by: jpercivall <JPercivall@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.