Skip to content

NIFI-3314 Adjusting Dockerfile for Docker Hub to use defaults for ARGs#1419

Closed
apiri wants to merge 1 commit intoapache:masterfrom
apiri:nifi-3314
Closed

NIFI-3314 Adjusting Dockerfile for Docker Hub to use defaults for ARGs#1419
apiri wants to merge 1 commit intoapache:masterfrom
apiri:nifi-3314

Conversation

@apiri
Copy link
Member

@apiri apiri commented Jan 14, 2017

NIFI-3314 Adjusting Dockerfile for Docker Hub to use defaults for ARGs such that it does not need supporting build script. Making use of openjdk base image as the java image has been deprecated.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • [-] Have you written or updated unit tests to verify your changes?
  • [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [-] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • [-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • [-] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • [-] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

such that it does not need supporting build script.  Making use of
openjdk base image as the java image has been deprecated.
@apiri apiri mentioned this pull request Jan 16, 2017
11 tasks
@olegz
Copy link
Contributor

olegz commented Jan 29, 2017

Reviewing . . .

@olegz
Copy link
Contributor

olegz commented Jan 29, 2017

LGTM, merging

@asfgit asfgit closed this in 67e2459 Jan 29, 2017
nickcarenza pushed a commit to nickcarenza/nifi that referenced this pull request Mar 3, 2017
such that it does not need supporting build script.  Making use of
openjdk base image as the java image has been deprecated.

This closes apache#1419
@apiri apiri deleted the nifi-3314 branch March 28, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants