NIFI-3291: Continue addressing issues from jQuery upgrade#1438
Closed
mcgilman wants to merge 2 commits intoapache:masterfrom
Closed
NIFI-3291: Continue addressing issues from jQuery upgrade#1438mcgilman wants to merge 2 commits intoapache:masterfrom
mcgilman wants to merge 2 commits intoapache:masterfrom
Conversation
- Fixing overflow calculation to determine if scrollbars are necessary. - Fixing styles with jquery ui slider usage.
Contributor
|
Reviewing.... |
scottyaslan
reviewed
Jan 27, 2017
| // adjust the field width for a potential scrollbar | ||
| var searchFieldContainer = $('#searchable-fields-container'); | ||
| if (searchFieldContainer.get(0).scrollHeight > searchFieldContainer.innerHeight()) { | ||
| if (searchFieldContainer.get(0).scrollHeight > Math.round(searchFieldContainer.innerHeight())) { |
Contributor
There was a problem hiding this comment.
@mcgilman I think this whole block of code is dead. The widths of the inputs for the "Search Events" dialog of the "Data Provenance" shell's $('#searchable-fields-container') are defined by CSS (in provenance.css line #141) and the widths being applied with this code are causing those inputs not to fill their available space.
Contributor
Author
There was a problem hiding this comment.
Yep, agreed. Will update.
- Removing dead code.
Contributor
|
Thanks @mcgilman this has been merged to master. |
nickcarenza
pushed a commit
to nickcarenza/nifi
that referenced
this pull request
Mar 3, 2017
- Removing dead code. This closes apache#1438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-3291: