Skip to content

[NIFI-3410] and styles for incorrect Processor Details dialog relationship description in Summary page#1488

Closed
scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan:NIFI-3410
Closed

[NIFI-3410] and styles for incorrect Processor Details dialog relationship description in Summary page#1488
scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan:NIFI-3410

Conversation

@scottyaslan
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mcgilman
Copy link
Contributor

Will review...

@mcgilman
Copy link
Contributor

@scottyaslan I think the inclusion of the processor-configuration.css needs to happen in the pom and summary.properties which define the files being included. The proposed solution does not work when aggregating/minifying.

Or alternatively just move the styles in question to processor-details.css which is already included. Or updated the JSP to use the same class. There is admittedly some duplication already there.

@scottyaslan scottyaslan changed the title [NIFI-3410] include processor-configuration.css in summary page [NIFI-3410] and styles for incorrect Processor Details dialog relationship description in Summary page Feb 10, 2017
@scottyaslan
Copy link
Contributor Author

@mcgilman I opted to move the styles in question to processor-details.css and updated this PR

@asfgit asfgit closed this in e4b74b3 Feb 10, 2017
@mcgilman
Copy link
Contributor

Thanks @scottyaslan. This has been merged to master!

aperepel pushed a commit to aperepel/nifi that referenced this pull request Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants