Skip to content

NIFI-3494 GenerateTableFetch Some JDBC Drivers Have Trouble With Name vs Label#1517

Closed
patricker wants to merge 1 commit intoapache:masterfrom
patricker:NIFI-3494
Closed

NIFI-3494 GenerateTableFetch Some JDBC Drivers Have Trouble With Name vs Label#1517
patricker wants to merge 1 commit intoapache:masterfrom
patricker:NIFI-3494

Conversation

@patricker
Copy link
Contributor

A tiny change to support JDBC drivers that are too helpful.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mattyb149
Copy link
Contributor

+1 LGTM, ran unit tests and contrib-check, ran on live NiFi against Oracle, MySQL, and Postgres DBs. Thank you for the contribution! Merging to master

@asfgit asfgit closed this in d689ac5 Mar 2, 2017
aperepel pushed a commit to aperepel/nifi that referenced this pull request Mar 29, 2017
…e vs Label

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes apache#1517
@patricker patricker deleted the NIFI-3494 branch October 4, 2017 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants