Skip to content

NIFI-3514 - Ensures ListGCPBucket triggers serially and forbids inputs#1526

Closed
trixpan wants to merge 1 commit intoapache:masterfrom
trixpan:NIFI-3514
Closed

NIFI-3514 - Ensures ListGCPBucket triggers serially and forbids inputs#1526
trixpan wants to merge 1 commit intoapache:masterfrom
trixpan:NIFI-3514

Conversation

@trixpan
Copy link
Contributor

@trixpan trixpan commented Feb 22, 2017

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • ~~~Have you written or updated unit tests to verify your changes?~~~
  • ~~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?~~~
  • ~~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~~
  • ~~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~~
  • ~~~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~~~

For documentation related changes:

  • [X ] ~~~Have you ensured that format looks appropriate for the output in which it is rendered?~~~

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@trixpan
Copy link
Contributor Author

trixpan commented Feb 22, 2017

@jvwing @gene-telligent - would you mind having a look ?

@jvwing
Copy link
Contributor

jvwing commented Feb 22, 2017

@trixpan - Good catch. I had asked @gene-telligent to remove INPUT_ALLOWED, but explicitly declaring INPUT_FORBIDDEN is a best practice. I will review.

@asfgit asfgit closed this in cefc02c Feb 22, 2017
@jvwing
Copy link
Contributor

jvwing commented Feb 22, 2017

@trixpan Thanks again for those annotation changes. I agree they are necessary for the stability and consistent usage of ListGCSBucket.

aperepel pushed a commit to aperepel/nifi that referenced this pull request Mar 29, 2017
This closes apache#1526.

Signed-off-by: James Wing <jvwing@gmail.com>
@trixpan trixpan deleted the NIFI-3514 branch May 15, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants