Skip to content

NIFI-3483 Added import statement to resolve failing tests.#1573

Closed
alopresto wants to merge 1 commit intoapache:masterfrom
alopresto:NIFI-3483
Closed

NIFI-3483 Added import statement to resolve failing tests.#1573
alopresto wants to merge 1 commit intoapache:masterfrom
alopresto:NIFI-3483

Conversation

@alopresto
Copy link
Contributor

@alopresto alopresto commented Mar 8, 2017

PR 1566 added NumberFormat to fix a locale-dependent test but missed the import statement.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@phrocker phrocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Resolves missing import.

@alopresto
Copy link
Contributor Author

Thanks for the quick verification. I need a committer but I think @apiri is on it.

@apiri
Copy link
Member

apiri commented Mar 8, 2017

Yeah, sorry about this. Serves me right for trying to eyeball the merge. Will get this in. Thanks

@alopresto
Copy link
Contributor Author

Aldrin's having a long day. The merge was successful but did not include the magic incantation to close the PR. Closing manually. Thanks all for the quick response.

@alopresto alopresto closed this Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants