Skip to content

NiFi-1356#158

Merged
asfgit merged 3 commits intoapache:masterfrom
jdye64:NIFI-1356
Jan 26, 2016
Merged

NiFi-1356#158
asfgit merged 3 commits intoapache:masterfrom
jdye64:NIFI-1356

Conversation

@jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jan 6, 2016

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use StandardValidators.CHARACTER_SET_VALIDATOR here instead of NON_EMPTY_VALIDATOR?

@jdye64 jdye64 changed the title NiFi-1356 NiFi-1156 Jan 13, 2016
@jdye64 jdye64 changed the title NiFi-1156 NiFi-1356 Jan 13, 2016
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 14, 2016

Taking Joe's feedback I merged the two processors InferAvroSchemaFromCSV and InferAvroSchemaFromJSON into a single processor InferAvroSchema.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the description got cut off half-way through a sentence?

@markap14
Copy link
Contributor

@jdye64 - this is awesome! A few NiFi-isms to work out, which i commented on inline but otherwise looks good to go. Thanks for all of the work that you've put in here!

@markap14
Copy link
Contributor

@jdye64 - it looks like this PR removes the entire nifi-nar-bundles/nifi-ldap-iaa-providers-bundle module. I'm guessing that was an accident :) Can you un-delete that please?

@asfgit asfgit merged commit 7008a30 into apache:master Jan 26, 2016
mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Dec 9, 2020
In addition:
- a more self-descriptive private variable name was used
- the test data set was made bigger (and more "robust").

This closes apache#158.

Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants