NIFI-3607 Allow multi files mode with fixed names#1608
Closed
pvillard31 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-3607 Allow multi files mode with fixed names#1608pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
will review |
trixpan
reviewed
Apr 10, 2017
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.Future; | ||
| import java.util.concurrent.ScheduledExecutorService; |
Contributor
There was a problem hiding this comment.
wasn't familiar with this. very handy!
Contributor
|
Shouldn't |
Contributor
Author
|
Sorry for the late answer @trixpan, just coming back from holidays. You're right, I should update the description, will do it later today. Thanks! |
Contributor
Author
|
Just pushed a commit to address your comment let me know if you want me to squash the PR. |
Contributor
|
@pvillard31 sorry for this but it seems PR is now in conflict with master. Would you mind rebasing? |
Contributor
Author
|
No problem at all @trixpan, I rebased against master. |
Contributor
|
@pvillard31 thanks for the rebase. LGTM. Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
=============================================
I slightly updated the test framework to allow a run schedule duration setting. It allows me to schedule multiple calls to the
onTriggermethod with a given duration between each call so that I can check what happens in case of events occurring while the processor is running (without callingonScheduled). With this new parameter, I added a unit test where a new file is created while the processor is running to check that the processor picks up the new file as expected.