Skip to content

NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/repository/or…#1625

Closed
trixpan wants to merge 1 commit intoapache:masterfrom
trixpan:NIFI-3650
Closed

NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/repository/or…#1625
trixpan wants to merge 1 commit intoapache:masterfrom
trixpan:NIFI-3650

Conversation

@trixpan
Copy link
Copy Markdown
Contributor

@trixpan trixpan commented Mar 26, 2017

…g/apache/nifi/

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • ~~~Have you written or updated unit tests to verify your changes?~~~
  • ~~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?~~~
  • ~~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~~
  • ~~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~~
  • ~~~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~~~

For documentation related changes:

  • ~~~Have you ensured that format looks appropriate for the output in which it is rendered?~~~

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@trixpan
Copy link
Copy Markdown
Contributor Author

trixpan commented Mar 26, 2017

@apiri @jfrazee - hopefully this will work.

@apiri
Copy link
Copy Markdown
Member

apiri commented Mar 27, 2017

@trixpan Do you think it makes more sense to use the before_cache directive instead? (https://docs.travis-ci.com/user/caching/#before_cache-phase) May just be struggling in the morning, but I believe this is likely the preferred approach.

@jfrazee
Copy link
Copy Markdown
Member

jfrazee commented Mar 27, 2017

@apiri I think there might be two tasks here to make sure everything is copacetic: (1) remove that part of the tree so we don't bother caching it/downloading it period and (2) removing it before the build just to make sure it's not there (will need that the first time this runs anyway if we don't invalidate the cache).

So I think it makes sense to add this but also keep the other.

@jfrazee
Copy link
Copy Markdown
Member

jfrazee commented Mar 27, 2017

@apiri Oh, I see now. You're saying move the one in script to before_cache.

@trixpan
Copy link
Copy Markdown
Contributor Author

trixpan commented Mar 27, 2017

@apiri good catch. I wasn't aware of that feature. I pushed a modified version. let me know what you think

@trixpan
Copy link
Copy Markdown
Contributor Author

trixpan commented Mar 27, 2017

I am obviously happy to remove the pre-build cache "rm -rf" but since it should not return error, so I reckon we can leave it there as a safety mechanism in case before_cache fails

@apiri
Copy link
Copy Markdown
Member

apiri commented Mar 28, 2017

@trixpan don't think removing it is necessary by any means. I also find it hard to say exactly how all these Travis options play out, but I think this is a step in the right direction. Scientific Method at its finest! Anyway, changes look good and I shall merge it.

@asfgit asfgit closed this in 8eb377e Mar 28, 2017
@trixpan trixpan deleted the NIFI-3650 branch April 1, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants