NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/repository/or…#1625
NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/repository/or…#1625trixpan wants to merge 1 commit intoapache:masterfrom
Conversation
|
@trixpan Do you think it makes more sense to use the before_cache directive instead? (https://docs.travis-ci.com/user/caching/#before_cache-phase) May just be struggling in the morning, but I believe this is likely the preferred approach. |
|
@apiri I think there might be two tasks here to make sure everything is copacetic: (1) remove that part of the tree so we don't bother caching it/downloading it period and (2) removing it before the build just to make sure it's not there (will need that the first time this runs anyway if we don't invalidate the cache). So I think it makes sense to add this but also keep the other. |
|
@apiri Oh, I see now. You're saying move the one in |
|
@apiri good catch. I wasn't aware of that feature. I pushed a modified version. let me know what you think |
|
I am obviously happy to remove the pre-build cache "rm -rf" but since it should not return error, so I reckon we can leave it there as a safety mechanism in case before_cache fails |
|
@trixpan don't think removing it is necessary by any means. I also find it hard to say exactly how all these Travis options play out, but I think this is a step in the right direction. Scientific Method at its finest! Anyway, changes look good and I shall merge it. |
…g/apache/nifi/
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.