Skip to content

NIFI-3018 removed flume-twitter-source due to usage of org.json cat-x lib#1666

Closed
mosermw wants to merge 1 commit intoapache:0.xfrom
mosermw:nifi-3018
Closed

NIFI-3018 removed flume-twitter-source due to usage of org.json cat-x lib#1666
mosermw wants to merge 1 commit intoapache:0.xfrom
mosermw:nifi-3018

Conversation

@mosermw
Copy link
Member

@mosermw mosermw commented Apr 12, 2017

This change is essentially copied from master to 0.x branch

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jskora
Copy link
Contributor

jskora commented Apr 27, 2017

Reviewing.

asfgit pushed a commit that referenced this pull request Apr 27, 2017
… lib

Signed-off-by: Joe Skora <jskora@apache.org>

This closes #1666
@jskora
Copy link
Contributor

jskora commented Apr 27, 2017

@mwmoser Committed to 0.x on 5072559.

@mosermw mosermw closed this Apr 27, 2017
@mosermw mosermw deleted the nifi-3018 branch October 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants