Skip to content

Nifi 3773#1734

Closed
thesolson wants to merge 2 commits intoapache:masterfrom
thesolson:NIFI-3773
Closed

Nifi 3773#1734
thesolson wants to merge 2 commits intoapache:masterfrom
thesolson:NIFI-3773

Conversation

@thesolson
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

=== Component Versions
You have access to information about the version of your Processors, Controller Services, and Reporting Tasks.
This is especially useful when you are working within a clustered environment with multiple NiFi instances running
different versions of a component or if you have upgraded to a newer version of a processors. The Add Processor,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... newer version of a processor ...

=== Component Versions
You have access to information about the version of your Processors, Controller Services, and Reporting Tasks.
This is especially useful when you are working within a clustered environment with multiple NiFi instances running
different versions of a component or if you have upgraded to a newer version of a processors. The Add Processor,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "processors" to "processor"

This is especially useful when you are working within a clustered environment with multiple NiFi instances running
different versions of a component or if you have upgraded to a newer version of a processors. The Add Processor,
Add Controller Service, and Add Reporting Task dialogs include a column identifying the component version, as well
as name of the component, the organization or group that created the component, and the NAR bundle that contains
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... as well as the name of the component ...

==== Filtering Components
When you are adding a component, you can filter based on originating source or version number.

To filter based on version, click the version column to display in ascending or descending version order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more like sorting than filtering.

Copy link
Contributor

@andrewmlim andrewmlim May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The columns sort, the Source drop-down filters. So maybe change the section to "Sorting and Filtering Components" also.

==== Understanding Version Dependencies
When you are configuring a component, you can also view information about version dependencies.

. Right-click your component and select Configure to display the Configure dialog for your component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs trailing '.'.

@alopresto
Copy link
Contributor

Hi @thesolson . @andrewmlim and I made some suggestions. If you are ok with these or have other comments, please add them. I'll then merge this. Thanks for the great contribution.

==== Understanding Version Dependencies
When you are configuring a component, you can also view information about version dependencies.

. Right-click your component and select Configure to display the Configure dialog for your component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a period at the end of sentence: "...for your component."

@asfgit asfgit closed this in 16f3776 May 2, 2017
@alopresto
Copy link
Contributor

With (out of band) confirmation from @thesolson , I've made the suggested changes and merged this.

@thesolson
Copy link
Contributor Author

thesolson commented May 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants