Skip to content

NIFI-3791 - added back pressure data into S2SStatusReportingTask#1745

Closed
pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31:NIFI-3791
Closed

NIFI-3791 - added back pressure data into S2SStatusReportingTask#1745
pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31:NIFI-3791

Conversation

@pvillard31
Copy link
Copy Markdown
Contributor

@pvillard31 pvillard31 commented May 3, 2017

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@alopresto
Copy link
Copy Markdown
Contributor

Reviewing...

@alopresto
Copy link
Copy Markdown
Contributor

Ran a sample flow but was getting some odd exceptions. Coordinating with Pierre offline but recommend another party reviews this PR. As it is not going in 1.2.0, there is plenty of time to have a person with more knowledge of the internals do that.

@ijokarumawak
Copy link
Copy Markdown
Member

@pvillard31 @alopresto I've reviewed the code, build and test the change to see if I can see any odd exceptions, but I haven't encountered any so far. I can see back-pressure status is reported properly. LGTM, +1.

I'm going to merge this into master. Thanks for the improvement!

@asfgit asfgit closed this in dc5e032 May 25, 2017
mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Nov 30, 2017
This closes apache#1745.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants