NIFI-3791 - added back pressure data into S2SStatusReportingTask#1745
Closed
pvillard31 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-3791 - added back pressure data into S2SStatusReportingTask#1745pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Reviewing... |
Contributor
|
Ran a sample flow but was getting some odd exceptions. Coordinating with Pierre offline but recommend another party reviews this PR. As it is not going in 1.2.0, there is plenty of time to have a person with more knowledge of the internals do that. |
Member
|
@pvillard31 @alopresto I've reviewed the code, build and test the change to see if I can see any odd exceptions, but I haven't encountered any so far. I can see back-pressure status is reported properly. LGTM, +1. I'm going to merge this into master. Thanks for the improvement! |
mattyb149
pushed a commit
to mattyb149/nifi
that referenced
this pull request
Nov 30, 2017
This closes apache#1745. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.