NIFI-3861: Fixed AvroReader nullable logical types issue#1779
Closed
ijokarumawak wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-3861: Fixed AvroReader nullable logical types issue#1779ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak wants to merge 1 commit intoapache:masterfrom
Conversation
- AvroReader did not convert logical types if those are defined with union - Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai ntaining both would be error-prone
Contributor
|
Reviewing... |
Contributor
|
All looks good. Thanks for catching this one too, @ijokarumawak! +1 merged to master. |
ijokarumawak
added a commit
to ijokarumawak/nifi
that referenced
this pull request
May 11, 2017
Previous fix apache#1779 refactored the way to check Logical type to use string constants. One of those refactoring used wrong constant mistakenly in normalizeValue method. Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion.
11 tasks
asfgit
pushed a commit
that referenced
this pull request
May 12, 2017
Previous fix #1779 refactored the way to check Logical type to use string constants. One of those refactoring used wrong constant mistakenly in normalizeValue method. Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion. Signed-off-by: Matt Burgess <mattyb149@apache.org> This closes #1782
josephxsxn
pushed a commit
to josephxsxn/nifi
that referenced
this pull request
May 15, 2017
- AvroReader did not convert logical types if those are defined with union - Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai ntaining both would be error-prone This closes apache#1779.
josephxsxn
pushed a commit
to josephxsxn/nifi
that referenced
this pull request
May 15, 2017
Previous fix apache#1779 refactored the way to check Logical type to use string constants. One of those refactoring used wrong constant mistakenly in normalizeValue method. Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion. Signed-off-by: Matt Burgess <mattyb149@apache.org> This closes apache#1782
mattyb149
pushed a commit
to mattyb149/nifi
that referenced
this pull request
Nov 30, 2017
- AvroReader did not convert logical types if those are defined with union - Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai ntaining both would be error-prone This closes apache#1779. Signed-off-by: Mark Payne <markap14@hotmail.com>
mattyb149
pushed a commit
to mattyb149/nifi
that referenced
this pull request
Nov 30, 2017
Previous fix apache#1779 refactored the way to check Logical type to use string constants. One of those refactoring used wrong constant mistakenly in normalizeValue method. Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion. Signed-off-by: Matt Burgess <mattyb149@apache.org> This closes apache#1782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ntaining both would be error-prone
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.