Skip to content

NIFI-3861: Fixed AvroReader nullable logical types issue#1779

Closed
ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak:nifi-3861
Closed

NIFI-3861: Fixed AvroReader nullable logical types issue#1779
ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak:nifi-3861

Conversation

@ijokarumawak
Copy link
Member

  • AvroReader did not convert logical types if those are defined with union
  • Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai
    ntaining both would be error-prone

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

- AvroReader did not convert logical types if those are defined with union
- Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai
ntaining both would be error-prone
@markap14
Copy link
Contributor

Reviewing...

@markap14
Copy link
Contributor

All looks good. Thanks for catching this one too, @ijokarumawak! +1 merged to master.

@asfgit asfgit closed this in 72de1cb May 10, 2017
ijokarumawak added a commit to ijokarumawak/nifi that referenced this pull request May 11, 2017
Previous fix apache#1779 refactored the way to check Logical type to use string constants.
One of those refactoring used wrong constant mistakenly in normalizeValue method.

Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion.
asfgit pushed a commit that referenced this pull request May 12, 2017
Previous fix #1779 refactored the way to check Logical type to use string constants.
One of those refactoring used wrong constant mistakenly in normalizeValue method.

Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion.

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes #1782
josephxsxn pushed a commit to josephxsxn/nifi that referenced this pull request May 15, 2017
- AvroReader did not convert logical types if those are defined with union
- Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai
ntaining both would be error-prone

This closes apache#1779.
josephxsxn pushed a commit to josephxsxn/nifi that referenced this pull request May 15, 2017
Previous fix apache#1779 refactored the way to check Logical type to use string constants.
One of those refactoring used wrong constant mistakenly in normalizeValue method.

Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion.

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes apache#1782
mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Nov 30, 2017
- AvroReader did not convert logical types if those are defined with union
- Consolidated createSchema method in AvroSchemaRegistry and AvroTypeUtil as both has identical implementation and mai
ntaining both would be error-prone

This closes apache#1779.

Signed-off-by: Mark Payne <markap14@hotmail.com>
mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Nov 30, 2017
Previous fix apache#1779 refactored the way to check Logical type to use string constants.
One of those refactoring used wrong constant mistakenly in normalizeValue method.

Fortunately, this defect is harmless since even though normalizeValue did not convert int to Time, DataTypeUtils.convertType does the same conversion.

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes apache#1782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants