Give extra info about input dir for Windows users. #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows users typically don't have to worry about supplying a trailing slash....until they work with some Java programs like Nifi. An input path such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput" that does not have a trailing slash will cause NiFi to parse everything in CharacterSetConversionSamples....not the TestInput folder. To remedy the situation, Windows users just need to add the trailing slash \ such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput\" and then NiFi is able to use the correct path and not pickup extra files from the unexpected parent folder. Giving this extra hint for Windows users is an easier workaround for now than doing Windows OS detection with http://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/SystemUtils.html#IS_OS_WINDOWS and providing workarounds. I think most Windows users and developers are aware of this kind of issue that we deal with everyday, and the extra hint should be enough.
Contributor
|
Hello - can you create a JIRA for this contrib and we can track/discuss there. Thanks! |
Contributor
Author
Contributor
|
thank you. We're digging in hard for the 050 release now so response time on this might be a bit slow. Thanks for contributing! |
mattyb149
pushed a commit
to mattyb149/nifi
that referenced
this pull request
Dec 9, 2020
This closes apache#181 Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows users typically don't have to worry about supplying a trailing slash....until they work with some Java programs like Nifi.
An input path such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput" that does not have a trailing slash will cause NiFi to parse everything in CharacterSetConversionSamples....not the TestInput folder. To remedy the situation, Windows users just need to add the trailing slash \ such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput" and then NiFi is able to use the correct path and not pickup extra files from the unexpected parent folder.
Giving this extra hint for Windows users is an easier workaround for now than doing Windows OS detection with http://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/SystemUtils.html#IS_OS_WINDOWS and providing workarounds.
I think most Windows users and developers are aware of this kind of issue that we deal with everyday, and the extra hint should be enough.