NIFI 3863 - Add LookupRecord, PartitionRecord processors#1825
NIFI 3863 - Add LookupRecord, PartitionRecord processors#1825markap14 wants to merge 2 commits intoapache:masterfrom
Conversation
|
@markap14 i think you dont want this in the PR Can you please squash when it is time for a formal review. I am going through this already though. This is cool stuff! |
|
I think for LookupAttribute it should either send all events to success (so it doesn't change/partition the stream other than to possibly enrich each record). I think if the lookup recordpath does not find anything the enrichment should just move on just like if the result record is empty. |
|
this thing is insanely useful. I will post my template when done reviewing. But this is supremely cool. |
…kupRecord processors. This required some refactoring of RecordSetWriter interface, so refactored that interface and all implementations and references of it
| @WritesAttribute(attribute="record.count", description="The number of records in an outgoing FlowFile"), | ||
| @WritesAttribute(attribute="mime.type", description="The MIME Type that the configured Record Writer indicates is appropriate"), | ||
| @WritesAttribute(attribute="<dynamic property name>", | ||
| description="For each dynamnic property that is added, an attribute may be added to the FlowFile. See the description for Dynamic Properties for more information.") |
There was a problem hiding this comment.
Minor typo, "dynamnic" should be "dynamic"
There was a problem hiding this comment.
Thanks. Addressed.
markap14
force-pushed
the
NIFI-3863
branch
2 times, most recently
from
fa88730 to
a3acacf
Compare
| } | ||
|
|
||
| } catch (final Exception ex) { | ||
| ex.printStackTrace(); |
There was a problem hiding this comment.
removing this and addressing a couple checkstyle issues
Signed-off-by: joewitt <joewitt@apache.org>
3 participants
I still need to add some more documentation and unit tests but wanted to go ahead and get this up so that if anyone has a chance to review or test they can do so.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.