Nifi-Camel Integration #186
Conversation
PuspenduBanerjee
changed the title
|
Any plan to pull this PR? |
|
Hello The community is working toward closing down on the 050 release so PR review bandwidth is limited right now. This PR represents a pretty significant step towards integration with another framework so we need to be thoughtful about the user experience. So while this represents a very interesting and compelling integration it may take a bit of time to get right. Now the PR as-is there are a few quick items I've noticed.
Very much appreciate the contribution and effort. Just need your understanding that things this important take time and a lot of diligence. Thanks |
|
Hello Joe, About Licensing, I am trying to add some maven plugin to automate that process and strongly believe that it should be centralized [ as rat plugin is checking License ]. About documentation, will it be a good idea to add a README file or do you have any other suggestion? And yes , there are some WIP code containing e.printStackStrack() , ThreadLocal etc. Working to get those removed. Thanks again. |
|
Ok understood. So given this initial feedback it sounds like you're still working on the PR and now have some things to work for it. When you are ready to submit again can you make sure the JIRA or the PR itself has a template and sample camel context that could be used to quickly get up to speed and try it out? |
|
Hello, [INFO] BUILD FAILURE |
|
@PuspenduBanerjee This was a commit that had reliance on repositories outside of those as part of the core build and has been reverted, more details are available in #147. Please pull/rebase the latest changes from master and you should be good to go. |
There was a problem hiding this comment.
Just to eliminate extra dependency, it is preferable to rely on native java classes if they provide such functionality and in this case they do for both List and Set (see Collections.unmodifiable. . .)
There was a problem hiding this comment.
I am seeing that other components are using the same and as we already have dependency on google-guava, I guess it should be okay. Please correct me otherwise.
There was a problem hiding this comment.
True and that is a potential for improvement. All I am saying is that this module brings a dependency that may have also some transient dependency for something that is not very well utilized. You are only using 2 classes from it and those two classes have adequate equivalents in JDK. Always think about the distribution of a NAR and its size. Rule of thumb, the thinner the better.
|
@apiri Thanks. It has built correctly with intermittent Heap issue. 👍 |
|
@apiri Again OOM in travis: testExecuteIngestAndUpdate(org.apache.nifi.processors.standard.TestExecuteStreamCommand) Time elapsed: 1.717 sec <<< ERROR! |
…-user to modify & maintain any Camel Route Definition without worrying about bundling with NiFi
…Support for loading external content as Camel-Context Definition
Adde more testcases, modified sample/test camel-context definition. incorporated review comments.
Modified test case for Multi-Threaded environment
|
Hello @joewitt PFA sample camel contexts. CamelProcessorTestingTemplate.xml.zip
I shall attach a presentation or some other visual representation, as we progress with the PR. Thanks. |
|
Closing PR, as found some issue in Integration test. Shall raise a new PR later. |
|
Moved to : PR #197 |
|
@joewitt Seeing that Travis build has started to skip tests. Is that a intended decision? |
|
definitely not intended. Can you send me a link? We've seen much better On Tue, Feb 2, 2016 at 10:13 AM, Puspendu Banerjee <notifications@github.com
|
|
@PuspenduBanerjee Certainly a bit confusing, but this is the standard sequence that Travis employs when building Maven based projects. This is for accumulating all dependencies up front before performing the actual build. Don't have the line numbers handy, but if you perform a search for:
You can see where the official and full build takes place. Hope this clears things up! |
|
@apiri Still have doubt. |
|
@PuspenduBanerjee Not sure I understand. From the linked PR in Travis I looked at one of the build logs (https://s3.amazonaws.com/archive.travis-ci.org/jobs/106415261/log.txt) and found the following among all the other typical test cases:
Do you have any additional details as to which tests you are seeing get skipped? To clarify, Travis maven builds are two steps:
Thanks! |
|
@apiri Sorry! It's my bad. I looked into a wrong location. |
|
No worries! Just wanted to make sure we weren't missing anything. |
…n Guide This closes apache#186. Signed-off-by: Aldrin Piri <aldrin@apache.org>
4 participants
It's initial working version of nifi-camel integration.
It Supports to load camel context from File, Classpath as well as to define and modify Routes on the fly.
Overall it's an implementation of feature request NIFI-924 [https://issues.apache.org/jira/browse/NIFI-924#]