Skip to content

[NIFI-4117] update connection config prioritizers to be contained wit…#1944

Closed
scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan:NIFI-4117
Closed

[NIFI-4117] update connection config prioritizers to be contained wit…#1944
scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan:NIFI-4117

Conversation

@scottyaslan
Copy link
Contributor

…hin their parent element

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31
Copy link
Contributor

Hey @scottyaslan, if doing that the prioritizer cannot be moved to "Selected prioritizers".

@scottyaslan
Copy link
Contributor Author

@pvillard31 I have updated this PR so that the containment of the drag/drop is set to an appropriate parent element.

@scottyaslan scottyaslan force-pushed the NIFI-4117 branch 2 times, most recently from eb1f6bc to 96b4551 Compare June 26, 2017 18:15
@pvillard31
Copy link
Contributor

+1, merging, thanks @scottyaslan

@asfgit asfgit closed this in 24e2981 Jun 26, 2017
mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Nov 30, 2017
…hin their parent element

This closes apache#1944.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants