NIFI-4060: Initial implementation of MergeRecord#1958
NIFI-4060: Initial implementation of MergeRecord#1958markap14 wants to merge 3 commits intoapache:masterfrom
Conversation
|
Reviewing... |
| @WritesAttributes({ | ||
| @WritesAttribute(attribute = "record.count", description = "The merged FlowFile will have a 'record.count' attribute indicating the number of records " | ||
| + "that were written to the FlowFile."), | ||
| @WritesAttribute(attribute = "mime.type", description = "The MIME Type indicated by the Record Writer"), |
There was a problem hiding this comment.
I can't find where mime.type is written to by this processor, does that need to be added?
There was a problem hiding this comment.
Line 325 of RecordBin adds it: https://github.com/apache/nifi/pull/1958/files#diff-62d8eee2f28a32e8414b634402285e12R325
…er it is completed; fixed issue that caused mime.type attribute not to be written properly if all incoming flowfiles already have a different value for that attribute
…formation; updated StandardProcessSession to produce more accurate logs in case of a session being committed/rolled back with open input/output streams
|
@mattyb149 I did realize that after setting mime.type we were overwriting it with the mime.type attribute of incoming FlowFiles. Sorry about that. I also found and fixed a threading issue in the RecordBinManager and improved the documentation around the Processor. I have pushed another commit that handles all of this. Please give it another review if you are able. |
|
+1 LGTM, verified most recent updates and re-ran my functional tests, also verified updated doc. Thanks much! Merging to master |
2 participants
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.