Skip to content

NIFI-4098 - Adjust ParseCEF to re-use bean validator in order to impr…#2013

Closed
trixpan wants to merge 1 commit intoapache:masterfrom
trixpan:NIFI-4098
Closed

NIFI-4098 - Adjust ParseCEF to re-use bean validator in order to impr…#2013
trixpan wants to merge 1 commit intoapache:masterfrom
trixpan:NIFI-4098

Conversation

@trixpan
Copy link
Contributor

@trixpan trixpan commented Jul 16, 2017

…ove performance

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31
Copy link
Contributor

From a coding point of view, it LGTM. On the L&N side, I'd appreciate another pair of eyes to be sure we're good to go. @joewitt ?

Also, @trixpan, I think the updated dependency is now available in Maven central, could you force another Travis build?

Apache BVal project
Copyright 2010-2016 The Apache Software Foundation.

This product includes software developed by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove lines 52-56.

Apache BVal project
Copyright 2010-2016 The Apache Software Foundation.

This product includes software developed by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove lines 34-38.

@joewitt
Copy link
Contributor

joewitt commented Jul 19, 2017

have verified L&N. Fixed an unrelated L&N finding and cleaned up the things i left comments on. Checked all dependencies and they're covered too. Good job. +1 merging to master

@asfgit asfgit closed this in a307ea3 Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants