Skip to content

NIFI-1923 - AttributesToJson regex property#2099

Closed
pvillard31 wants to merge 2 commits intoapache:masterfrom
pvillard31:NIFI-1923
Closed

NIFI-1923 - AttributesToJson regex property#2099
pvillard31 wants to merge 2 commits intoapache:masterfrom
pvillard31:NIFI-1923

Conversation

@pvillard31
Copy link
Copy Markdown
Contributor

@pvillard31 pvillard31 commented Aug 18, 2017

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+ "the matching attributes. This property can be used in combination with the attributes "
+ "list property.")
.required(false)
.addValidator(StandardValidators.REGULAR_EXPRESSION_VALIDATOR)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about supporting Expression Language for this field? You can keep the same validator, although that doesn't allow validation against flow files, just Variable Registry properties and such. You could support regexes from flow file attributes too, but you'd need a new validator and it would recompile each time, which might not be a great idea from a performance perspective.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to add EL evaluation against variable registry, system properties, etc. But won't add the evaluation against the flow file as it will impact the performances as you said.

@mattyb149
Copy link
Copy Markdown
Contributor

+1 LGTM, ran the tests, verified EL is supported (via variables not flow files). Thanks for the improvement! Merging to master

@asfgit asfgit closed this in e62417e Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants