NIFI-1923 - AttributesToJson regex property#2099
NIFI-1923 - AttributesToJson regex property#2099pvillard31 wants to merge 2 commits intoapache:masterfrom
Conversation
| + "the matching attributes. This property can be used in combination with the attributes " | ||
| + "list property.") | ||
| .required(false) | ||
| .addValidator(StandardValidators.REGULAR_EXPRESSION_VALIDATOR) |
There was a problem hiding this comment.
What do you think about supporting Expression Language for this field? You can keep the same validator, although that doesn't allow validation against flow files, just Variable Registry properties and such. You could support regexes from flow file attributes too, but you'd need a new validator and it would recompile each time, which might not be a great idea from a performance perspective.
There was a problem hiding this comment.
Agree to add EL evaluation against variable registry, system properties, etc. But won't add the evaluation against the flow file as it will impact the performances as you said.
|
+1 LGTM, ran the tests, verified EL is supported (via variables not flow files). Thanks for the improvement! Merging to master |
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.