Skip to content

NIFI-3941 - Clarify tab name for controller...#2124

Closed
yuri1969 wants to merge 1 commit intoapache:masterfrom
yuri1969:NIFI-3941
Closed

NIFI-3941 - Clarify tab name for controller...#2124
yuri1969 wants to merge 1 commit intoapache:masterfrom
yuri1969:NIFI-3941

Conversation

@yuri1969
Copy link
Contributor

@yuri1969 yuri1969 commented Sep 1, 2017

...level controller services dialog

  • Changed the tab title since sharing the name makes things
    less clear for newcomers.
  • Suggested info sentence is omitted.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

...level controller services dialog

* Changed the tab title since sharing the name makes things
less clear for newcomers.
* Suggested info sentence is omitted.
@yuri1969
Copy link
Contributor Author

yuri1969 commented Sep 1, 2017

@alopresto There already is an info sentence at the bottom. Should the dialog really contain two info sentences?

@mcgilman
Copy link
Contributor

mcgilman commented Sep 5, 2017

@yuri1969 @alopresto Just wanted to chime in that technically the Controller Services in the Controller Settings are for Reporting Tasks and other Controller Services denied there. For instance, a Reporting Task could reference Controller Service A and Controller Service A could reference Controller Service B. In this case, both Controller Service A and Controller Service B would be defined in this listing. The existing sentence that @yuri1969 mentioned states:

Listed services are available to all Reporting Tasks and services defined in the Controller Settings.

@alopresto
Copy link
Contributor

Reviewing...

@asfgit asfgit closed this in 20d23e8 Sep 8, 2017
@alopresto
Copy link
Contributor

Ran contrib-check and all tests pass. Verified in app that the global CS tab name is different from the flow controller services tab. +1, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants