New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4352: Add CLOB and NCLOB support to PutSQL #2145

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ijokarumawak
Contributor

ijokarumawak commented Sep 12, 2017

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak

This comment has been minimized.

Show comment
Hide comment
@ijokarumawak

ijokarumawak Sep 12, 2017

Contributor

Added followings:

  • CLOB and NCLOB support to PutSQL
  • NCLOB support to ExecuteSQL

Confirmed it can insert and select CLOB and NCLOB columns. For NCLOB, I've tested Japanese characters are inserted and retrieved successfully.

A template is available here in Gist:
https://gist.github.com/ijokarumawak/451085b01349c7e6e83bcc42182ecffc

CREATE TABLE clob_test (
  i INT not null,
  c CLOB,
  nc NCLOB,
  CONSTRAINT clob_test_pk PRIMARY KEY (i)
);
Contributor

ijokarumawak commented Sep 12, 2017

Added followings:

  • CLOB and NCLOB support to PutSQL
  • NCLOB support to ExecuteSQL

Confirmed it can insert and select CLOB and NCLOB columns. For NCLOB, I've tested Japanese characters are inserted and retrieved successfully.

A template is available here in Gist:
https://gist.github.com/ijokarumawak/451085b01349c7e6e83bcc42182ecffc

CREATE TABLE clob_test (
  i INT not null,
  c CLOB,
  nc NCLOB,
  CONSTRAINT clob_test_pk PRIMARY KEY (i)
);
@pvillard31

This comment has been minimized.

Show comment
Hide comment
@pvillard31

pvillard31 Sep 14, 2017

Contributor

+1, ran full build with contrib-check and made few tests with provided template. Merging to master, thanks @ijokarumawak

Contributor

pvillard31 commented Sep 14, 2017

+1, ran full build with contrib-check and made few tests with provided template. Merging to master, thanks @ijokarumawak

@asfgit asfgit closed this in 1e70e24 Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment