NIFI-3926 - Edit Template information#2222
Conversation
* Added a new edit dialog to 'Global Menu - Templates'. * Omitted Process Group Id editing functionality. * Added a unit test for template DAO update logic.
|
|
||
| private void canUpdateTemplate(final String name, final String templateId, final TemplateDTO processGroupTemplate) { | ||
| // prevent renaming to another template's name | ||
| if (name.equals(processGroupTemplate.getName()) && !templateId.equals(processGroupTemplate.getId())) { |
There was a problem hiding this comment.
Do we want the name comparison to be case-insensitive (or at least trimmed)?
There was a problem hiding this comment.
@alopresto I was sloppy with that name validation, my mistake.
|
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
2 participants
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.