NIFI-4552 Add mime.type and record.count Write Attributes to QueryRec…#2242
Closed
andrewmlim wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-4552 Add mime.type and record.count Write Attributes to QueryRec…#2242andrewmlim wants to merge 1 commit intoapache:masterfrom
andrewmlim wants to merge 1 commit intoapache:masterfrom
Conversation
mattyb149
reviewed
Oct 31, 2017
| @WritesAttributes({ | ||
| @WritesAttribute(attribute = "mime.type", description = "Sets the mime.type attribute to the MIME Type specified by the Record Writer"), | ||
| @WritesAttribute(attribute = "record.count", description = "The number of records selected by the query") | ||
| }) |
Contributor
There was a problem hiding this comment.
Checkstyle failed with trailing whitespace here
[WARNING] src/main/java/org/apache/nifi/processors/standard/QueryRecord.java[110] (regexp) RegexpSinglelineJava: Line has trailing whitespace.
Otherwise LGTM, thanks! Will merge after contrib-check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ord doc