Skip to content

NIFI-4473: Fixed SelectHiveQL flowfile handling during error conditions#2247

Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-4473_1
Closed

NIFI-4473: Fixed SelectHiveQL flowfile handling during error conditions#2247
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-4473_1

Conversation

@mattyb149
Copy link
Contributor

So the behavior is inconsistent with other processors like ExecuteSQL, but it has always been that way, so this fix is just to ensure it isn't any worse :)

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31
Copy link
Contributor

+1, full build OK and ran few tests to confirm error scenario and provenance lineage. Merging to master, thanks @mattyb149 !

@asfgit asfgit closed this in 5cd8a3e Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants