NIFI-4575 Added ability to convert from a date to a timestamp within …#2255
NIFI-4575 Added ability to convert from a date to a timestamp within …#2255MikeThomsen wants to merge 1 commit intoapache:masterfrom
Conversation
|
@mattyb149 do you think you could take a look at this? It's only a 3 line change to one of the conversion APIs in the Record API package. The scenario where it came up was Mongo's client API returns a java.util.Date object for dates and to convert a Mongo date to a Record API timestamp field, I had to enable a conversion of java.util.Date to a java.sql.Timestamp. Without this change, you cannot load a Mongo date and assign it to a timestamp field in a record (so it breaks the Mongo LookupService if it's missing.) |
|
@m-hogue Since you have done a lot with the record api, could take you a look at this? It's only a few lines. |
|
Reviewing... |
|
+1 LGTM, ran a full build with contrib-check, tested with a MongoDBLookupService, verified that the error occurs when retrieving a Date field, but is successfully converted with this fix. Thanks for the improvement! Merging to master |
…the record API.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.