Skip to content

NIFI-4575 Added ability to convert from a date to a timestamp within …#2255

Closed
MikeThomsen wants to merge 1 commit intoapache:masterfrom
MikeThomsen:NIFI-4575
Closed

NIFI-4575 Added ability to convert from a date to a timestamp within …#2255
MikeThomsen wants to merge 1 commit intoapache:masterfrom
MikeThomsen:NIFI-4575

Conversation

@MikeThomsen
Copy link
Copy Markdown
Contributor

@MikeThomsen MikeThomsen commented Nov 6, 2017

…the record API.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Copy Markdown
Contributor Author

MikeThomsen commented Nov 6, 2017

@mattyb149 do you think you could take a look at this? It's only a 3 line change to one of the conversion APIs in the Record API package. The scenario where it came up was Mongo's client API returns a java.util.Date object for dates and to convert a Mongo date to a Record API timestamp field, I had to enable a conversion of java.util.Date to a java.sql.Timestamp. Without this change, you cannot load a Mongo date and assign it to a timestamp field in a record (so it breaks the Mongo LookupService if it's missing.)

@MikeThomsen
Copy link
Copy Markdown
Contributor Author

@m-hogue Since you have done a lot with the record api, could take you a look at this? It's only a few lines.

@mattyb149
Copy link
Copy Markdown
Contributor

Reviewing...

@mattyb149
Copy link
Copy Markdown
Contributor

+1 LGTM, ran a full build with contrib-check, tested with a MongoDBLookupService, verified that the error occurs when retrieving a Date field, but is successfully converted with this fix. Thanks for the improvement! Merging to master

@asfgit asfgit closed this in c70a86e Nov 13, 2017
@MikeThomsen MikeThomsen deleted the NIFI-4575 branch August 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants