Skip to content

NIFI-4588 Added the ability to use update operators like and to Put…#2259

Closed
MikeThomsen wants to merge 1 commit intoapache:masterfrom
MikeThomsen:NIFI-4588
Closed

NIFI-4588 Added the ability to use update operators like and to Put…#2259
MikeThomsen wants to merge 1 commit intoapache:masterfrom
MikeThomsen:NIFI-4588

Conversation

@MikeThomsen
Copy link
Contributor

@MikeThomsen MikeThomsen commented Nov 9, 2017

…Mongo.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mattyb149
Copy link
Contributor

+1 LGTM, ran full build with unit tests and contrib-check (will remove some dead code while merging), and tested with regular and operator-enabled documents. A couple parting comments:

  1. Are you interested in adding this functionality to PutMongoRecord as well? If so please feel free to write a Jira and/or implement it :)
  2. Now that it supports operators, should we consider allowing an update query rather than just a key?

In any case, this is great, thanks for the improvement! Merging to master

@asfgit asfgit closed this in fe3f288 Nov 13, 2017
@MikeThomsen
Copy link
Contributor Author

Thanks!

  1. We can't because "$" is an illegal starting character in Avro. That's why I was grumbling about "$date" operations on the mailing list. Fortunately, for simple puts there is a good work around.

  2. Yeah, we could. I think that would need to support EL too.

@dyunggertrude
Copy link

Hi,
I need some help

I try to use putMongo 1.5.0 with the ability to not replacing the whole collection (option With operators enabled in Update Mode)

image
the flow file is like this :
{ "$set": {
"type":"Cc",
"nmess":14488,
"idgtr":"C-00000-0000-00088-0000-00000-CMF-RMF",
"last_update":"2018-01-10T09:32:35",
"libelle":"Bonifacio_Estefan. " }
}

When i launch nifi process, attributes not listed in my flow are deleted !!!

What's wrong in my configuration

@MikeThomsen MikeThomsen deleted the NIFI-4588 branch August 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments