#77864: Fixed error handling for the large file (OutOfMemory error)#2297
Closed
artemgolubnichenko wants to merge 1 commit intoapache:masterfrom
Closed
#77864: Fixed error handling for the large file (OutOfMemory error)#2297artemgolubnichenko wants to merge 1 commit intoapache:masterfrom
artemgolubnichenko wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
can definitely appreciate the intent of this patch but I suspect we'll need to handle this differently. Once an OOME has happened the JVM might still function well but things can be unpredictable/unreliable. Rather than catching such a thing and warning the user we should instead prevent data of a certain size from being retrieved via this mechanism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.