Skip to content

NIFI-4619: Enable EL on AWSCredentialsProviderControllerService properties#2344

Closed
mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91:NIFI-4619
Closed

NIFI-4619: Enable EL on AWSCredentialsProviderControllerService properties#2344
mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91:NIFI-4619

Conversation

@mgaido91
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? N/A
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? N/A
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? N/A
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? N/A

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered? N/A

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mgaido91
Copy link
Contributor Author

@jvwing @mans2singh may I kindly ask you some help reviewing this? I saw you are the last contributors on it... Thanks!

@mgaido91 mgaido91 changed the title NIFI-4619: Enable expression language on AWSCredentialsProviderControllerService properties NIFI-4619: Enable EL on AWSCredentialsProviderControllerService properties Dec 15, 2017
@jvwing
Copy link
Contributor

jvwing commented Dec 16, 2017

Reviewing...

@asfgit asfgit closed this in 9217e2f Dec 17, 2017
@jvwing
Copy link
Contributor

jvwing commented Dec 17, 2017

Thanks, @mgaido91! The code change looks good and works good. And thanks for tuning up the tests appropriately.

@mgaido91
Copy link
Contributor Author

thank you for your review @jvwing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants