NIFI-4826 Fixed azure.blobname in ListAzureBlobStorage#2440
NIFI-4826 Fixed azure.blobname in ListAzureBlobStorage#2440zenfenan wants to merge 1 commit intoapache:masterfrom
Conversation
| attributes.put("azure.secondaryUri", entity.getSecondaryUri()); | ||
| attributes.put("azure.blobname", entity.getName()); | ||
| attributes.put("azure.blobname", entity.getBlobName()); | ||
| attributes.put("filename", entity.getName()); |
There was a problem hiding this comment.
I'm a bit worried about this change. It's going to change the value of a core attribute (filename) that could break the behavior of existing workflows. I'd rather user another attribute name if we still want to have an attribute for entity.getName(). Thoughts?
There was a problem hiding this comment.
I dint use filename just because to find a use for entity.getName() The filename attribute for ListAzureBlobStorage as of 1.5.0 has a large number as its name, much like the filenames of flowfiles generated by GenerateFlowFiles processor. The change here is intended to provide a meaningful filename i.e. the actual name of the blob.
My assumption was that people would either be updating the filename using UpdateAttribute/ExecuteScript (parsing the azure.primaryUri and taking the file name) or simply ignoring the filename altogether. In that case, this change won't affect, right? For ex: If people are overwriting filename attribute, whatever this contribution produces as a filename will still be overwritten ( I am again going with the assumption that they would either be parsing the filename from the azure.primaryUri attribute since that's the only attribute that provides us the blob name). If they aren't touching the filename attribute, then this would just produce a meaningful filename. Hope you understood what I'm trying to say.
There was a problem hiding this comment.
You're right. I actually completely missed the fact that this change is for a processor with no input relationship... Disregard my comment.
|
LGTM, merging to master, thanks @zenfenan |
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#2440.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.