NIFI-4828: Fix MergeContent to process all ready bins#2444
Closed
ijokarumawak wants to merge 3 commits intoapache:masterfrom
Closed
NIFI-4828: Fix MergeContent to process all ready bins#2444ijokarumawak wants to merge 3 commits intoapache:masterfrom
ijokarumawak wants to merge 3 commits intoapache:masterfrom
Conversation
Before this fix, MergeContent only processed the first bin even if there were multiple bins. There were two unit tests marked with Ignore those had been failing because of this.
Contributor
|
@ijokarumawak thanks for addressing! Code review looks good. All unit tests pass (including the ones that were @ignored previously!) and some local testing all worked out exactly as expected. +1 merged to master. |
zenfenan
pushed a commit
to zenfenan/nifi
that referenced
this pull request
Feb 14, 2018
Before this fix, MergeContent only processed the first bin even if there were multiple bins. There were two unit tests marked with Ignore those had been failing because of this. This closes apache#2444. Signed-off-by: Mark Payne <markap14@hotmail.com>
apiri
pushed a commit
to apiri/incubator-nifi
that referenced
this pull request
May 10, 2018
Before this fix, MergeContent only processed the first bin even if there were multiple bins. There were two unit tests marked with Ignore those had been failing because of this. This closes apache#2444. Signed-off-by: Mark Payne <markap14@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE to reviewers
This pull request has 3 commits intentionally. The first one is sufficient to address NIFI-4828. The other two commits are further refactoring those are not required, but should be incorporated, too. I didn't create dedicated JIRAs for those since they're too trivial.
Please squash commits and merge if all of those look fine. Or remove the 2nd or 3rd commit if it looks over engineered. Thank you!
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.