NIFI-4840 Fix formatting for expression language guide for toRadix an…#2449
NIFI-4840 Fix formatting for expression language guide for toRadix an…#2449Leah-Anderson wants to merge 1 commit intoapache:masterfrom
Conversation
| *Description*: [.description]#Converts the Subject from a Base 10 number to a different Radix (or number base). An optional | ||
| second argument can be used to indicate the minimum number of characters to be used. If the converted value | ||
| has fewer than this number of characters, the number will be padded with leading zeroes. | ||
| has fewer than this number of characters, the number will be padded with leading zeroes.# |
There was a problem hiding this comment.
I think that, instead of moving the # character, it'd be better to just remove the carriage return between this line and the next one, no? (same applies for fromRadix). Otherwise, the display is a bit weird in the doc:
https://github.com/Leah-Anderson/nifi/blob/a445ee4d141ea1218d3cf5c47abb5171c5890f43/nifi-docs/src/main/asciidoc/expression-language-guide.adoc#fromradix
There was a problem hiding this comment.
I was thinking the way it was made it seem like a call out to "hey this is important to note" but I can see it either way. I've pushed an update to remove the carriage return :)
a445ee4 to
7e3a028
Compare
zenfenan
left a comment
There was a problem hiding this comment.
I was also under the impression that the last line was made to be highlighted as sort of a 'note' to users. Just realized that's not the case by looking at the description of the others. The latest commit fixes it. LGTM
|
+1, merging to master, thanks @Leah-Anderson @zenfenan |
…d fromRadix
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.