Skip to content

NIFI-3502: Upgrading D3 version#2471

Closed
mcgilman wants to merge 3 commits into
apache:masterfrom
mcgilman:NIFI-3502
Closed

NIFI-3502: Upgrading D3 version#2471
mcgilman wants to merge 3 commits into
apache:masterfrom
mcgilman:NIFI-3502

Conversation

@mcgilman
Copy link
Copy Markdown
Contributor

NIFI-3502:

  • Upgrading to D3 version 4.

- Upgrading to D3 version 4.
@scottyaslan
Copy link
Copy Markdown
Contributor

Will review...

@andrewmlim
Copy link
Copy Markdown
Contributor

Started to test this out. One thing I am noticing that is different from 1.5.0 is that if I select multiple processors, then deselect everything, the operate palette still says "Multiple components selected" for a couple seconds before it eventually clears

@andrewmlim
Copy link
Copy Markdown
Contributor

Upon further testing, it is really any selection and deselection where this issue occurs. The previously selected component lingers in the Operate palette even when not selected.

- Ensuring that upon deselection, the monitor palette is updated accordingly.
@mcgilman
Copy link
Copy Markdown
Contributor Author

Just pushed a new commit that addresses @andrewmlim findings.

nfCanvasUtils.setURLParameters();

// inform Angular app values have changed
nfNgBridge.digest();
Copy link
Copy Markdown
Contributor

@scottyaslan scottyaslan Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is throwing an error. I think it should be put on the call stack once to be ran after this function completes. Something like:
setTimeout(function() {
nfNgBridge.digest();
}, 0);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part? The .digest() was necessary to address @andrewmlim comments.

- Preventing digest() during an ongoing apply() or digest() lifecycle.
@asfgit asfgit closed this in ba9e72e Feb 20, 2018
@scottyaslan
Copy link
Copy Markdown
Contributor

Thanks @mcgilman this has been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants