NIFI-3502: Upgrading D3 version#2471
Conversation
- Upgrading to D3 version 4.
|
Will review... |
|
Started to test this out. One thing I am noticing that is different from 1.5.0 is that if I select multiple processors, then deselect everything, the operate palette still says "Multiple components selected" for a couple seconds before it eventually clears |
|
Upon further testing, it is really any selection and deselection where this issue occurs. The previously selected component lingers in the Operate palette even when not selected. |
- Ensuring that upon deselection, the monitor palette is updated accordingly.
|
Just pushed a new commit that addresses @andrewmlim findings. |
| nfCanvasUtils.setURLParameters(); | ||
|
|
||
| // inform Angular app values have changed | ||
| nfNgBridge.digest(); |
There was a problem hiding this comment.
This is throwing an error. I think it should be put on the call stack once to be ran after this function completes. Something like:
setTimeout(function() {
nfNgBridge.digest();
}, 0);
There was a problem hiding this comment.
Which part? The .digest() was necessary to address @andrewmlim comments.
- Preventing digest() during an ongoing apply() or digest() lifecycle.
|
Thanks @mcgilman this has been merged to master. |
NIFI-3502: