NIFI-4774: Allow user to choose which write-ahead log implementation …#2487
NIFI-4774: Allow user to choose which write-ahead log implementation …#2487markap14 wants to merge 1 commit intoapache:masterfrom
Conversation
…should be used by the WriteAheadFlowFileRepository
mattyb149
left a comment
mattyb149
left a comment
There was a problem hiding this comment.
I left a couple of minor comments that I can take care of during merge, I'll be testing in the meantime and will give others in the community time to try this out as well.
| private static final String FLOWFILE_REPOSITORY_DIRECTORY_PREFIX = "nifi.flowfile.repository.directory"; | ||
| private static final String WRITE_AHEAD_LOG_IMPL = "nifi.flowfile.repository.wal.implementation"; | ||
|
|
||
| // TODO: Update Admin Guide |
There was a problem hiding this comment.
I think this TODO is DONE :)
There was a problem hiding this comment.
Yup, this is done :) If you get a chance to merge, please delete the comment.
| numPartitions = 0; | ||
| checkpointExecutor = null; | ||
| flowFileRepositoryPath = null; | ||
| walImplementation = null; |
There was a problem hiding this comment.
Should this be DEFAULT_WAL_IMPLEMENTATION?
There was a problem hiding this comment.
It doesn't really matter what it's set to - that constructor will only be used for service loading and no method in the class will ever be called.
|
I tested this and I was able to switch back and forth between MinimalLockingWriteAheadLog and SequentialAccessWriteAheadLog. +1 from me. |
|
@mattyb149 and @markap14 with the 1.6.0 release approaching, do you think we've allowed enough time for review and testing? Is this good to go? Thanks. |
|
+1 LGTM, I tested switching back and forth and everything looks good. Thanks for the improvement! Merging to master |
3 participants
…should be used by the WriteAheadFlowFileRepository
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.