Skip to content

NIFI-4920 Skipping sensitive properties when updating component prope…#2505

Closed
bbende wants to merge 1 commit intoapache:masterfrom
bbende:NIFI-4920
Closed

NIFI-4920 Skipping sensitive properties when updating component prope…#2505
bbende wants to merge 1 commit intoapache:masterfrom
bbende:NIFI-4920

Conversation

@bbende
Copy link
Contributor

@bbende bbende commented Mar 2, 2018

…rties from versioned component

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@markap14
Copy link
Contributor

markap14 commented Mar 2, 2018

Thanks @bbende! Code looks good. Verified that i was able to recreate issue and that it went away with the patch. +1 merged to master.

@asfgit asfgit closed this in 179e967 Mar 2, 2018
asfgit pushed a commit that referenced this pull request Mar 4, 2018
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
Signed-off-by: James Wing <jvwing@gmail.com>

This closes #2505.
@jvwing
Copy link
Contributor

jvwing commented Mar 4, 2018

The extra close is a result of my carelessness, sorry. That should have been for PR #2506.

JohannesDaniel pushed a commit to JohannesDaniel/nifi that referenced this pull request Mar 6, 2018
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
Signed-off-by: James Wing <jvwing@gmail.com>

This closes apache#2505.
apiri pushed a commit to apiri/incubator-nifi that referenced this pull request May 10, 2018
…rties from versioned component. This closes apache#2505.

Signed-off-by: Mark Payne <markap14@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants