Skip to content

NIFI-4950 Defining behavior for MergeContent when more than 1 FlowFil…#2557

Closed
markobean wants to merge 1 commit intoapache:masterfrom
markobean:NIFI-4950
Closed

NIFI-4950 Defining behavior for MergeContent when more than 1 FlowFil…#2557
markobean wants to merge 1 commit intoapache:masterfrom
markobean:NIFI-4950

Conversation

@markobean
Copy link
Contributor

…e has the same fragment.index value

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mosermw
Copy link
Member

mosermw commented Mar 16, 2018

Reviewed and tested; behavior in the presence of a duplicate fragment is fixed; duplicate is sent to failure. I fixed a typo and used FragmentAttributes.FRAGMENT_INDEX enum in place of "fragment.index" strings.
+1, merging. Thanks for fixing this @markobean.

@asfgit asfgit closed this in 8b2c5b7 Mar 16, 2018
@markobean markobean deleted the NIFI-4950 branch January 30, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants