Skip to content

NIFI-5062: Removed hbase-client dependecy from hbase bundle#2636

Closed
zenfenan wants to merge 1 commit intoapache:masterfrom
zenfenan:NIFI-5062
Closed

NIFI-5062: Removed hbase-client dependecy from hbase bundle#2636
zenfenan wants to merge 1 commit intoapache:masterfrom
zenfenan:NIFI-5062

Conversation

@zenfenan
Copy link
Contributor

@zenfenan zenfenan commented Apr 16, 2018

Since the MockHBaseClientService and TestPutHBaseRecord extensively uses the Bytes from hbase-client class, I have created a new class with the same name and literally copied the necessary methods from the actual Bytes class to this one.


Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Contributor

@zenfenan have you had a chance to run this against a live HBase cluster?

@zenfenan
Copy link
Contributor Author

@MikeThomsen Yes. I tested it against my local one.

Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran build, it looks fine. Since everything that matters is in the HBase client, I feel confident with merging this.

@asfgit asfgit closed this in 1dbfcb9 Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants