Skip to content

NIFI-5095: Suppress SET property parse failure at Hive processors#2645

Closed
ijokarumawak wants to merge 2 commits intoapache:masterfrom
ijokarumawak:nifi-5095
Closed

NIFI-5095: Suppress SET property parse failure at Hive processors#2645
ijokarumawak wants to merge 2 commits intoapache:masterfrom
ijokarumawak:nifi-5095

Conversation

@ijokarumawak
Copy link
Member

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31
Copy link
Contributor

@ijokarumawak - could this be related to https://issues.apache.org/jira/browse/NIFI-5044 ?
If yes, then the same issue would occur with 'add jar ...' for example, right?
Based on the discussion on the JIRA, it's probably best to include two properties for pre and post query statements. Thoughts?

@ijokarumawak
Copy link
Member Author

@pvillard31 Thanks for pointing that. Yes, it's indirectly related to NIFI-5044. If pre/post query statement is added to SelectHiveQuery, then statements such as 'set x=y' or 'add jar..' would be written there and will not be passed to findTableNames method I assume.

However, for PutHiveQL, such queries can be bundled in the same FlowFile content. I filtered out only 'set x=y' statement, but it's not enough. 'add jar ...' fails similarly. Moreover, if we're going to filter out those commands, we need to care all commands in this wiki page I guess.
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Cli
It requires something like CommandProcessorFactory.
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java#L51

That will be overkill for this JIRA and findTableNames purpose. I will update this PR to simply lower the log level to INFO. Thanks!

Log warning message if other unknown Exception is thrown.
@mattyb149
Copy link
Contributor

+1 LGTM, ran build and unit tests. Thanks for this improvement! Merging to master

@asfgit asfgit closed this in c575a98 Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants