NIFI-5095: Suppress SET property parse failure at Hive processors#2645
NIFI-5095: Suppress SET property parse failure at Hive processors#2645ijokarumawak wants to merge 2 commits intoapache:masterfrom
Conversation
|
@ijokarumawak - could this be related to https://issues.apache.org/jira/browse/NIFI-5044 ? |
|
@pvillard31 Thanks for pointing that. Yes, it's indirectly related to NIFI-5044. If pre/post query statement is added to SelectHiveQuery, then statements such as 'set x=y' or 'add jar..' would be written there and will not be passed to findTableNames method I assume. However, for PutHiveQL, such queries can be bundled in the same FlowFile content. I filtered out only 'set x=y' statement, but it's not enough. 'add jar ...' fails similarly. Moreover, if we're going to filter out those commands, we need to care all commands in this wiki page I guess. That will be overkill for this JIRA and findTableNames purpose. I will update this PR to simply lower the log level to INFO. Thanks! |
Log warning message if other unknown Exception is thrown.
|
+1 LGTM, ran build and unit tests. Thanks for this improvement! Merging to master |
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.