Skip to content

NIFI-5105: Improvements for nifi-aws-bundle#2664

Closed
zenfenan wants to merge 1 commit intoapache:masterfrom
zenfenan:NIFI-5105
Closed

NIFI-5105: Improvements for nifi-aws-bundle#2664
zenfenan wants to merge 1 commit intoapache:masterfrom
zenfenan:NIFI-5105

Conversation

@zenfenan
Copy link
Contributor

@zenfenan zenfenan commented Apr 28, 2018

Introduces the following improvements:

  • The AWS SDK version has been updated to the latest release (1.11.319)
  • Removed aws-java-sdk which packed unnecessary artifacts i.e. artifacts not used by the nifi-aws-bundle. The nifi-aws-nar now weights ~50 MB less

Test with S3 and it works well.


Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jvwing
Copy link
Contributor

jvwing commented Apr 28, 2018

Reviewing...

@asfgit asfgit closed this in ba84ad1 Apr 28, 2018
@jvwing
Copy link
Contributor

jvwing commented Apr 28, 2018

Thanks, @zenfenan, this looks good.

  • Full build with contrib-check passes
  • nifi-aws-processors integration tests pass
  • Manual testing with an S3 flow worked fine

And great news that the NAR file is down to ~15 MB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants