Skip to content

NIFI-5134 Explicitly requesting UGI to relogin before attempting to g…#2667

Closed
jtstorck wants to merge 1 commit intoapache:masterfrom
jtstorck:NIFI-5134
Closed

NIFI-5134 Explicitly requesting UGI to relogin before attempting to g…#2667
jtstorck wants to merge 1 commit intoapache:masterfrom
jtstorck:NIFI-5134

Conversation

@jtstorck
Copy link
Contributor

…et a DB connection in HiveConnectionPool

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jtstorck
Copy link
Contributor Author

@mattyb149, @markap14, would you please review this PR?

@mattyb149
Copy link
Contributor

+1 LGTM, looks like it will work like a barrier sync, the first one in will relogin if necessary, the rest will no-op, which means there won't be a race condition / threading issue when some of the threads call doAs. Thanks for the improvement! Merging to master

@asfgit asfgit closed this in 3ad3243 May 3, 2018
apiri pushed a commit to apiri/incubator-nifi that referenced this pull request May 10, 2018
…et a DB connection in HiveConnectionPool

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#2667
@jtstorck jtstorck deleted the NIFI-5134 branch May 16, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants