New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIFI-5215] Upgrade AngularJS to v1.7.0. Also, adding package-lock.js… #2721

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@scottyaslan
Contributor

scottyaslan commented May 18, 2018

…on to source control

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mcgilman

This comment has been minimized.

Show comment
Hide comment
@mcgilman

mcgilman May 22, 2018

Contributor

Will review...

Contributor

mcgilman commented May 22, 2018

Will review...

@mcgilman

This comment has been minimized.

Show comment
Hide comment
@mcgilman

mcgilman May 29, 2018

Contributor

Thanks @scottyaslan! This has been merged to master.

Contributor

mcgilman commented May 29, 2018

Thanks @scottyaslan! This has been merged to master.

@asfgit asfgit closed this in 9aa7e65 May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment