NIFI-5225: Purge event data from event repository when Connectable is removed#2732
Closed
FrederikP wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-5225: Purge event data from event repository when Connectable is removed#2732FrederikP wants to merge 1 commit intoapache:masterfrom
FrederikP wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@FrederikP all looks good here. I have merged the changes to master. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
Clean install ran through just fine, but contrib-check complained about an unrelated package
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
[ ] Have you ensured that format looks appropriate for the output in which it is rendered?I introduced the option to purge data from the FlowFileEventRepository (the 5 min ring buffer) to fix this:
https://issues.apache.org/jira/browse/NIFI-5225
And it works for our setup.