Skip to content

NIFI-5225: Purge event data from event repository when Connectable is removed#2732

Closed
FrederikP wants to merge 1 commit intoapache:masterfrom
FrederikP:master
Closed

NIFI-5225: Purge event data from event repository when Connectable is removed#2732
FrederikP wants to merge 1 commit intoapache:masterfrom
FrederikP:master

Conversation

@FrederikP
Copy link
Contributor

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    Clean install ran through just fine, but contrib-check complained about an unrelated package
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

I introduced the option to purge data from the FlowFileEventRepository (the 5 min ring buffer) to fix this:
https://issues.apache.org/jira/browse/NIFI-5225

And it works for our setup.

@markap14
Copy link
Contributor

@FrederikP all looks good here. I have merged the changes to master. Thanks for the fix!

@asfgit asfgit closed this in d75ba16 May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants