NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.#2761
Closed
alopresto wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.#2761alopresto wants to merge 1 commit intoapache:masterfrom
alopresto wants to merge 1 commit intoapache:masterfrom
Conversation
Removed relevant unit tests.
Contributor
|
Reviewing.. |
Contributor
|
Looks fine to me after looking at https://issues.apache.org/jira/browse/NIFI-4942, executed encrypting a properties file which worked and attempted to use the -z param which no longer works. Had a look through the code changes/remaining code and didn't see anything related to the hashing being left behind. |
kevdoran
approved these changes
Jun 11, 2018
Contributor
kevdoran
left a comment
There was a problem hiding this comment.
+1
looks good. merging to master...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was added to support external integration with Apache Ambari. Ambari developers then discovered a problem with the joint proposal and we built a different way to accomplish the goal. This behavior should be removed so it does not go in a release and need to be supported unnecessarily.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.