Skip to content

NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.#2761

Closed
alopresto wants to merge 1 commit intoapache:masterfrom
alopresto:NIFI-5209
Closed

NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.#2761
alopresto wants to merge 1 commit intoapache:masterfrom
alopresto:NIFI-5209

Conversation

@alopresto
Copy link
Contributor

This feature was added to support external integration with Apache Ambari. Ambari developers then discovered a problem with the joint proposal and we built a different way to accomplish the goal. This behavior should be removed so it does not go in a release and need to be supported unnecessarily.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@thenatog
Copy link
Contributor

thenatog commented Jun 5, 2018

Reviewing..

@thenatog
Copy link
Contributor

thenatog commented Jun 5, 2018

Looks fine to me after looking at https://issues.apache.org/jira/browse/NIFI-4942, executed encrypting a properties file which worked and attempted to use the -z param which no longer works. Had a look through the code changes/remaining code and didn't see anything related to the hashing being left behind.

Copy link
Contributor

@kevdoran kevdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

looks good. merging to master...

@asfgit asfgit closed this in d02cd4f Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants