Skip to content

NIFI-5445 changing property for listen processors to allow binding to…#2909

Closed
nicholasmhughes wants to merge 2 commits intoapache:masterfrom
nicholasmhughes:NIFI-5445
Closed

NIFI-5445 changing property for listen processors to allow binding to…#2909
nicholasmhughes wants to merge 2 commits intoapache:masterfrom
nicholasmhughes:NIFI-5445

Conversation

@nicholasmhughes
Copy link

… an IP address instead of an interface

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@markap14
Copy link
Contributor

@nicholasmhughes This isn't really something that we can do right now, as it would be a breaking change. Also, it takes away some important functionality for some users. In a clustered environment, the IP address will not be the same. However, for many setups, the interface name will be consistent across the machines, so providing an interface name makes more sense in that case.
If you would like to be able to specify an IP address, the PR would need to introduce the new property but leave the old one intact and working. Additionally, the customValidate method would need to be added/updated to ensure that only one of the properties is set.

@nicholasmhughes
Copy link
Author

@markap14 Understood. I figured a complete property change would get shot down, and I didn't even think about the implications in a cluster. However, the main problem is that virtual interfaces (e.g. eth0:1) aren't able to be specified in the existing parameter due to issues I listed in the Jira ticket. Do you know of a way to overcome this barrier?

@joewitt
Copy link
Contributor

joewitt commented Mar 25, 2021

closing due to inactivity

@joewitt joewitt closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants